Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30338cf0 authored by Sjur Brændeland's avatar Sjur Brændeland Committed by Ohad Ben-Cohen
Browse files

remoteproc: fix missing fault indication in error-path 



If rproc_find_rsc_table() fails, rproc_fw_boot() must set
return-value before jumping to clean_up label. Otherwise no
error value is returned.

Signed-off-by: default avatarSjur Brændeland <sjur.brandeland@stericsson.com>
Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
Cc: stable@vger.kernel.org
parent e981f6d4

drivers/remoteproc/remoteproc_core.c

+3 −1
Original line number Diff line number Diff line
@@ -1041,8 +1041,10 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw) 


	/* look for the resource table */

	table = rproc_find_rsc_table(rproc, fw->data, fw->size, &tablesz);

	if (!table)

	if (!table) {

		ret = -EINVAL;

		goto clean_up;

	}



	/* handle fw resources which are required to boot rproc */

	ret = rproc_handle_boot_rsc(rproc, table, tablesz);