Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2fd091f3 authored by roel kluin's avatar roel kluin Committed by Paul Mackerras
Browse files

powerpc/macintosh: Fix unsigned check in smu_sat_get_sdb_partition() 



i2c_smbus_read_word_data() returns a s32, which may be negative
but unsigned len cannot be negative.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent e6a437eb

drivers/macintosh/windfarm_smu_sat.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -87,11 +87,12 @@ struct smu_sdbp_header *smu_sat_get_sdb_partition(unsigned int sat_id, int id, 
		return NULL;

		return NULL;

	}

	}





	len = i2c_smbus_read_word_data(&sat->i2c, 9);

	err = i2c_smbus_read_word_data(&sat->i2c, 9);

	if (len < 0) {

	if (err < 0) {

		printk(KERN_ERR "smu_sat_get_sdb_part rd len error\n");

		printk(KERN_ERR "smu_sat_get_sdb_part rd len error\n");

		return NULL;

		return NULL;

	}

	}

	len = err;

	if (len == 0) {

	if (len == 0) {

		printk(KERN_ERR "smu_sat_get_sdb_part no partition %x\n", id);

		printk(KERN_ERR "smu_sat_get_sdb_part no partition %x\n", id);

		return NULL;

		return NULL;