Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f1eab8d authored by Daniel Kurtz's avatar Daniel Kurtz Committed by Inki Dae
Browse files

drm/exynos/fbdev: don't set fix.smem/mmio_{start,len} 



Kernel access to the eyxnos fbdev framebuffer is via its gem object's
kernel mapping (kvaddr, stored in info->screen_base).

User space access is provided by mmap(), read() and write() of /dev/fb/fb0.
These functions also only use screen_base/screen_size().

Therefore, it is not necessary to set fix->smem_{start,len} or
fix->mmio_{start,len} fields.

This avoids leaking kernel, physical and dma mapped addresses to user
space via the ioctls FBIOGET_VSCREENINFO and FBIOGET_FSCREENINFO.

Signed-off-by: default avatarDaniel Kurtz <djkurtz@chromium.org>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent 182407a6

drivers/gpu/drm/exynos/exynos_drm_fbdev.c

+0 −7
Original line number Diff line number Diff line
@@ -123,14 +123,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, 


	dev->mode_config.fb_base = (resource_size_t)buffer->dma_addr;

	fbi->screen_base = buffer->kvaddr + offset;

	if (is_drm_iommu_supported(dev))

		fbi->fix.smem_start = (unsigned long)

			(page_to_phys(sg_page(buffer->sgt->sgl)) + offset);

	else

		fbi->fix.smem_start = (unsigned long)buffer->dma_addr;



	fbi->screen_size = size;

	fbi->fix.smem_len = size;



	return 0;

}