Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e5e0b89 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman
Browse files

Staging: et131x: Clean up number fields



Lots of RX typedefs are just low bits of a u32, so clean them all up in one
go and just work them directly.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 67947125
Loading
Loading
Loading
Loading
+36 −87
Original line number Original line Diff line number Diff line
@@ -339,19 +339,10 @@ typedef union _RXDMA_CSR_t {
/*
/*
 * structure for number of packets done reg in rxdma address map
 * structure for number of packets done reg in rxdma address map
 * located at address 0x200C
 * located at address 0x200C
 *
 * 31-8: unused
 * 7-0: num done
 */
 */
typedef union _RXDMA_NUM_PKT_DONE_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:24;	/* bits 8-31 */
		u32 num_done:8;	/* bits 0-7 */
#else
		u32 num_done:8;	/* bits 0-7 */
		u32 unused:24;	/* bits 8-31 */
#endif
	} bits;
} RXDMA_NUM_PKT_DONE_t, *PRXDMA_NUM_PKT_DONE_t;


/*
/*
 * structure for max packet time reg in rxdma address map
 * structure for max packet time reg in rxdma address map
@@ -394,19 +385,10 @@ typedef union _RXDMA_NUM_PKT_DONE_t {
/*
/*
 * structure for packet status ring number of descriptors reg in rxdma address
 * structure for packet status ring number of descriptors reg in rxdma address
 * map.  Located at address 0x2028
 * map.  Located at address 0x2028
 *
 * 31-12: unused
 * 11-0: psr ndes
 */
 */
typedef union _RXDMA_PSR_NUM_DES_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:20;		/* bits 12-31 */
		u32 psr_ndes:12;	/* bit 0-11 */
#else
		u32 psr_ndes:12;	/* bit 0-11 */
		u32 unused:20;		/* bits 12-31 */
#endif
	} bits;
} RXDMA_PSR_NUM_DES_t, *PRXDMA_PSR_NUM_DES_t;


/*
/*
 * structure for packet status ring available offset reg in rxdma address map
 * structure for packet status ring available offset reg in rxdma address map
@@ -449,36 +431,18 @@ typedef union _RXDMA_PSR_FULL_OFFSET_t {
/*
/*
 * structure for packet status ring access index reg in rxdma address map
 * structure for packet status ring access index reg in rxdma address map
 * located at address 0x2034
 * located at address 0x2034
 *
 * 31-5: unused
 * 4-0: psr_ai
 */
 */
typedef union _RXDMA_PSR_ACCESS_INDEX_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:27;	/* bits 5-31 */
		u32 psr_ai:5;	/* bits 0-4 */
#else
		u32 psr_ai:5;	/* bits 0-4 */
		u32 unused:27;	/* bits 5-31 */
#endif
	} bits;
} RXDMA_PSR_ACCESS_INDEX_t, *PRXDMA_PSR_ACCESS_INDEX_t;


/*
/*
 * structure for packet status ring minimum descriptors reg in rxdma address
 * structure for packet status ring minimum descriptors reg in rxdma address
 * map.  Located at address 0x2038
 * map.  Located at address 0x2038
 *
 * 31-12: unused
 * 11-0: psr_min
 */
 */
typedef union _RXDMA_PSR_MIN_DES_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:20;	/* bits 12-31 */
		u32 psr_min:12;	/* bits 0-11 */
#else
		u32 psr_min:12;	/* bits 0-11 */
		u32 unused:20;	/* bits 12-31 */
#endif
	} bits;
} RXDMA_PSR_MIN_DES_t, *PRXDMA_PSR_MIN_DES_t;


/*
/*
 * structure for free buffer ring base lo address reg in rxdma address map
 * structure for free buffer ring base lo address reg in rxdma address map
@@ -495,6 +459,9 @@ typedef union _RXDMA_PSR_MIN_DES_t {
/*
/*
 * structure for free buffer ring number of descriptors reg in rxdma address
 * structure for free buffer ring number of descriptors reg in rxdma address
 * map.  Located at address 0x2044
 * map.  Located at address 0x2044
 *
 * 31-10: unused
 * 9-0: fbr ndesc
 */
 */
typedef union _RXDMA_FBR_NUM_DES_t {
typedef union _RXDMA_FBR_NUM_DES_t {
	u32 value;
	u32 value;
@@ -524,36 +491,18 @@ typedef union _RXDMA_FBR_NUM_DES_t {
/*
/*
 * structure for free buffer cache 0 full offset reg in rxdma address map
 * structure for free buffer cache 0 full offset reg in rxdma address map
 * located at address 0x2050
 * located at address 0x2050
 *
 * 31-5: unused
 * 4-0: fbc rdi
 */
 */
typedef union _RXDMA_FBC_RD_INDEX_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:27;	/* bits 5-31 */
		u32 fbc_rdi:5;	/* bit 0-4 */
#else
		u32 fbc_rdi:5;	/* bit 0-4 */
		u32 unused:27;	/* bits 5-31 */
#endif
	} bits;
} RXDMA_FBC_RD_INDEX_t, *PRXDMA_FBC_RD_INDEX_t;


/*
/*
 * structure for free buffer ring 0 minimum descriptor reg in rxdma address map
 * structure for free buffer ring 0 minimum descriptor reg in rxdma address map
 * located at address 0x2054
 * located at address 0x2054
 *
 * 31-10: unused
 * 9-0: fbr min
 */
 */
typedef union _RXDMA_FBR_MIN_DES_t {
	u32 value;
	struct {
#ifdef _BIT_FIELDS_HTOL
		u32 unused:22;	/* bits 10-31 */
		u32 fbr_min:10;	/* bits 0-9 */
#else
		u32 fbr_min:10;	/* bits 0-9 */
		u32 unused:22;	/* bits 10-31 */
#endif
	} bits;
} RXDMA_FBR_MIN_DES_t, *PRXDMA_FBR_MIN_DES_t;


/*
/*
 * structure for free buffer ring 1 base address lo reg in rxdma address map
 * structure for free buffer ring 1 base address lo reg in rxdma address map
@@ -599,32 +548,32 @@ typedef struct _RXDMA_t { /* Location: */
	RXDMA_CSR_t csr;				/*  0x2000 */
	RXDMA_CSR_t csr;				/*  0x2000 */
	u32 dma_wb_base_lo;				/*  0x2004 */
	u32 dma_wb_base_lo;				/*  0x2004 */
	u32 dma_wb_base_hi;				/*  0x2008 */
	u32 dma_wb_base_hi;				/*  0x2008 */
	RXDMA_NUM_PKT_DONE_t num_pkt_done;		/*  0x200C */
	u32 num_pkt_done;				/*  0x200C */
	u32 max_pkt_time;				/*  0x2010 */
	u32 max_pkt_time;				/*  0x2010 */
	u32 rxq_rd_addr;				/*  0x2014 */
	u32 rxq_rd_addr;				/*  0x2014 */
	u32 rxq_rd_addr_ext;				/*  0x2018 */
	u32 rxq_rd_addr_ext;				/*  0x2018 */
	u32 rxq_wr_addr;				/*  0x201C */
	u32 rxq_wr_addr;				/*  0x201C */
	u32 psr_base_lo;				/*  0x2020 */
	u32 psr_base_lo;				/*  0x2020 */
	u32 psr_base_hi;				/*  0x2024 */
	u32 psr_base_hi;				/*  0x2024 */
	RXDMA_PSR_NUM_DES_t psr_num_des;		/*  0x2028 */
	u32 psr_num_des;				/*  0x2028 */
	RXDMA_PSR_AVAIL_OFFSET_t psr_avail_offset;	/*  0x202C */
	RXDMA_PSR_AVAIL_OFFSET_t psr_avail_offset;	/*  0x202C */
	RXDMA_PSR_FULL_OFFSET_t psr_full_offset;	/*  0x2030 */
	RXDMA_PSR_FULL_OFFSET_t psr_full_offset;	/*  0x2030 */
	RXDMA_PSR_ACCESS_INDEX_t psr_access_index;	/*  0x2034 */
	u32 psr_access_index;				/*  0x2034 */
	RXDMA_PSR_MIN_DES_t psr_min_des;		/*  0x2038 */
	u32 psr_min_des;				/*  0x2038 */
	u32 fbr0_base_lo;				/*  0x203C */
	u32 fbr0_base_lo;				/*  0x203C */
	u32 fbr0_base_hi;				/*  0x2040 */
	u32 fbr0_base_hi;				/*  0x2040 */
	RXDMA_FBR_NUM_DES_t fbr0_num_des;		/*  0x2044 */
	u32 fbr0_num_des;				/*  0x2044 */
	u32 fbr0_avail_offset;				/*  0x2048 */
	u32 fbr0_avail_offset;				/*  0x2048 */
	u32 fbr0_full_offset;				/*  0x204C */
	u32 fbr0_full_offset;				/*  0x204C */
	RXDMA_FBC_RD_INDEX_t fbr0_rd_index;		/*  0x2050 */
	u32 fbr0_rd_index;				/*  0x2050 */
	RXDMA_FBR_MIN_DES_t fbr0_min_des;		/*  0x2054 */
	u32 fbr0_min_des;				/*  0x2054 */
	u32 fbr1_base_lo;				/*  0x2058 */
	u32 fbr1_base_lo;				/*  0x2058 */
	u32 fbr1_base_hi;				/*  0x205C */
	u32 fbr1_base_hi;				/*  0x205C */
	RXDMA_FBR_NUM_DES_t fbr1_num_des;		/*  0x2060 */
	u32 fbr1_num_des;				/*  0x2060 */
	u32 fbr1_avail_offset;				/*  0x2064 */
	u32 fbr1_avail_offset;				/*  0x2064 */
	u32 fbr1_full_offset;				/*  0x2068 */
	u32 fbr1_full_offset;				/*  0x2068 */
	RXDMA_FBC_RD_INDEX_t fbr1_rd_index;		/*  0x206C */
	u32 fbr1_rd_index;				/*  0x206C */
	RXDMA_FBR_MIN_DES_t fbr1_min_des;		/*  0x2070 */
	u32 fbr1_min_des;				/*  0x2070 */
} RXDMA_t, *PRXDMA_t;
} RXDMA_t, *PRXDMA_t;


/* END OF RXDMA REGISTER ADDRESS MAP */
/* END OF RXDMA REGISTER ADDRESS MAP */
+11 −11
Original line number Original line Diff line number Diff line
@@ -598,7 +598,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	struct _rx_ring_t *rx_local = &etdev->RxRing;
	struct _rx_ring_t *rx_local = &etdev->RxRing;
	PFBR_DESC_t fbr_entry;
	PFBR_DESC_t fbr_entry;
	u32 entry;
	u32 entry;
	RXDMA_PSR_NUM_DES_t psr_num_des;
	u32 psr_num_des;
	unsigned long flags;
	unsigned long flags;


	/* Halt RXDMA to perform the reconfigure.  */
	/* Halt RXDMA to perform the reconfigure.  */
@@ -623,12 +623,12 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	writel((u32) ((u64)rx_local->pPSRingPa >> 32),
	writel((u32) ((u64)rx_local->pPSRingPa >> 32),
	       &rx_dma->psr_base_hi);
	       &rx_dma->psr_base_hi);
	writel((u32) rx_local->pPSRingPa, &rx_dma->psr_base_lo);
	writel((u32) rx_local->pPSRingPa, &rx_dma->psr_base_lo);
	writel(rx_local->PsrNumEntries - 1, &rx_dma->psr_num_des.value);
	writel(rx_local->PsrNumEntries - 1, &rx_dma->psr_num_des);
	writel(0, &rx_dma->psr_full_offset.value);
	writel(0, &rx_dma->psr_full_offset.value);


	psr_num_des.value = readl(&rx_dma->psr_num_des.value);
	psr_num_des = readl(&rx_dma->psr_num_des) & 0xFFF;
	writel((psr_num_des.bits.psr_ndes * LO_MARK_PERCENT_FOR_PSR) / 100,
	writel((psr_num_des * LO_MARK_PERCENT_FOR_PSR) / 100,
	       &rx_dma->psr_min_des.value);
	       &rx_dma->psr_min_des);


	spin_lock_irqsave(&etdev->RcvLock, flags);
	spin_lock_irqsave(&etdev->RcvLock, flags);


@@ -650,7 +650,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	 */
	 */
	writel((u32) (rx_local->Fbr1Realpa >> 32), &rx_dma->fbr1_base_hi);
	writel((u32) (rx_local->Fbr1Realpa >> 32), &rx_dma->fbr1_base_hi);
	writel((u32) rx_local->Fbr1Realpa, &rx_dma->fbr1_base_lo);
	writel((u32) rx_local->Fbr1Realpa, &rx_dma->fbr1_base_lo);
	writel(rx_local->Fbr1NumEntries - 1, &rx_dma->fbr1_num_des.value);
	writel(rx_local->Fbr1NumEntries - 1, &rx_dma->fbr1_num_des);
	writel(ET_DMA10_WRAP, &rx_dma->fbr1_full_offset);
	writel(ET_DMA10_WRAP, &rx_dma->fbr1_full_offset);


	/* This variable tracks the free buffer ring 1 full position, so it
	/* This variable tracks the free buffer ring 1 full position, so it
@@ -658,7 +658,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	 */
	 */
	rx_local->local_Fbr1_full = ET_DMA10_WRAP;
	rx_local->local_Fbr1_full = ET_DMA10_WRAP;
	writel(((rx_local->Fbr1NumEntries * LO_MARK_PERCENT_FOR_RX) / 100) - 1,
	writel(((rx_local->Fbr1NumEntries * LO_MARK_PERCENT_FOR_RX) / 100) - 1,
	       &rx_dma->fbr1_min_des.value);
	       &rx_dma->fbr1_min_des);


#ifdef USE_FBR0
#ifdef USE_FBR0
	/* Now's the best time to initialize FBR0 contents */
	/* Now's the best time to initialize FBR0 contents */
@@ -672,7 +672,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)


	writel((u32) (rx_local->Fbr0Realpa >> 32), &rx_dma->fbr0_base_hi);
	writel((u32) (rx_local->Fbr0Realpa >> 32), &rx_dma->fbr0_base_hi);
	writel((u32) rx_local->Fbr0Realpa, &rx_dma->fbr0_base_lo);
	writel((u32) rx_local->Fbr0Realpa, &rx_dma->fbr0_base_lo);
	writel(rx_local->Fbr0NumEntries - 1, &rx_dma->fbr0_num_des.value);
	writel(rx_local->Fbr0NumEntries - 1, &rx_dma->fbr0_num_des);
	writel(ET_DMA10_WRAP, &rx_dma->fbr0_full_offset);
	writel(ET_DMA10_WRAP, &rx_dma->fbr0_full_offset);


	/* This variable tracks the free buffer ring 0 full position, so it
	/* This variable tracks the free buffer ring 0 full position, so it
@@ -680,7 +680,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	 */
	 */
	rx_local->local_Fbr0_full = ET_DMA10_WRAP;
	rx_local->local_Fbr0_full = ET_DMA10_WRAP;
	writel(((rx_local->Fbr0NumEntries * LO_MARK_PERCENT_FOR_RX) / 100) - 1,
	writel(((rx_local->Fbr0NumEntries * LO_MARK_PERCENT_FOR_RX) / 100) - 1,
	       &rx_dma->fbr0_min_des.value);
	       &rx_dma->fbr0_min_des);
#endif
#endif


	/* Program the number of packets we will receive before generating an
	/* Program the number of packets we will receive before generating an
@@ -688,7 +688,7 @@ void ConfigRxDmaRegs(struct et131x_adapter *etdev)
	 * For version B silicon, this value gets updated once autoneg is
	 * For version B silicon, this value gets updated once autoneg is
	 *complete.
	 *complete.
	 */
	 */
	writel(PARM_RX_NUM_BUFS_DEF, &rx_dma->num_pkt_done.value);
	writel(PARM_RX_NUM_BUFS_DEF, &rx_dma->num_pkt_done);


	/* The "time_done" is not working correctly to coalesce interrupts
	/* The "time_done" is not working correctly to coalesce interrupts
	 * after a given time period, but rather is giving us an interrupt
	 * after a given time period, but rather is giving us an interrupt
@@ -712,7 +712,7 @@ void SetRxDmaTimer(struct et131x_adapter *etdev)
	if ((etdev->linkspeed == TRUEPHY_SPEED_100MBPS) ||
	if ((etdev->linkspeed == TRUEPHY_SPEED_100MBPS) ||
	    (etdev->linkspeed == TRUEPHY_SPEED_10MBPS)) {
	    (etdev->linkspeed == TRUEPHY_SPEED_10MBPS)) {
		writel(0, &etdev->regs->rxdma.max_pkt_time);
		writel(0, &etdev->regs->rxdma.max_pkt_time);
		writel(1, &etdev->regs->rxdma.num_pkt_done.value);
		writel(1, &etdev->regs->rxdma.num_pkt_done);
	}
	}
}
}