Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2e3ea7e7 authored by Shahed Shaikh's avatar Shahed Shaikh Committed by David S. Miller
Browse files

qlcnic: Fix external loopback test. 



Driver was not handling external loopback diagnostic
test request.

Signed-off-by: default avatarShahed Shaikh <shahed.shaikh@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 01b91f4c

drivers/net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c

+10 −2
Original line number Diff line number Diff line
@@ -150,6 +150,7 @@ static const char qlcnic_gstrings_test[][ETH_GSTRING_LEN] = { 
	"Link_Test_on_offline",

	"Interrupt_Test_offline",

	"Internal_Loopback_offline",

	"External_Loopback_offline",

	"EEPROM_Test_offline"

};
@@ -1026,9 +1027,16 @@ qlcnic_diag_test(struct net_device *dev, struct ethtool_test *eth_test, 
		if (data[3])

			eth_test->flags |= ETH_TEST_FL_FAILED;



		data[4] = qlcnic_eeprom_test(dev);

		if (eth_test->flags & ETH_TEST_FL_EXTERNAL_LB) {

			data[4] = qlcnic_loopback_test(dev, QLCNIC_ELB_MODE);

			if (data[4])

				eth_test->flags |= ETH_TEST_FL_FAILED;

			eth_test->flags |= ETH_TEST_FL_EXTERNAL_LB_DONE;

		}



		data[5] = qlcnic_eeprom_test(dev);

		if (data[5])

			eth_test->flags |= ETH_TEST_FL_FAILED;

	}

}