Commit 2e1f3aa5 authored Jan 20, 2018 by Daeho Jeong Committed by Jaegeuk Kim Feb 10, 2018

f2fs: correct removexattr behavior for null valued extended attribute



__vfs_removexattr() transfers "NULL" value to the setxattr handler of
the f2fs filesystem in order to remove the extended attribute. But,
__f2fs_setxattr() just ignores the removal request when the value of
the extended attribute is already NULL. We have to remove the extended
attribute itself even if the value of that is already NULL.

We can reporduce this bug with the below:

1. touch file
2. setfattr -n "user.foo" file
3. setfattr -x "user.foo" file
4. getfattr -d file
> user.foo

Signed-off-by: Daeho Jeong <daeho.jeong@samsung.com>
Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com>
Tested-by: Hobin Woo <hobin.woo@samsung.com>
Tested-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent c8330bdc

fs/f2fs/xattr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -642,7 +642,7 @@ static int __f2fs_setxattr(struct inode *inode, int index,
		goto exit;
		}

		if (f2fs_xattr_value_same(here, value, size))
		if (value && f2fs_xattr_value_same(here, value, size))
		goto exit;
		} else if ((flags & XATTR_REPLACE)) {
		error = -ENODATA;