Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2df3b0b7 authored by John W. Linville's avatar John W. Linville
Browse files

rsi: make rsi_dbg a regular function 



This is to address reports of this:

In file included from drivers/net/wireless/rsi/rsi_mgmt.h:22:0,
                 from drivers/net/wireless/rsi/rsi_91x_core.c:17:
drivers/net/wireless/rsi/rsi_91x_core.c: In function 'rsi_dbg':
drivers/net/wireless/rsi/rsi_main.h:44:20: error: function 'rsi_dbg' can never be inlined because it uses variable argument lists
 static inline void rsi_dbg(u32 zone, const char *fmt, ...)

Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent dad0d04f

drivers/net/wireless/rsi/rsi_91x_main.c

+23 −0
Original line number Diff line number Diff line
@@ -31,6 +31,29 @@ u32 rsi_zone_enabled = /* INFO_ZONE | 
			0;

EXPORT_SYMBOL_GPL(rsi_zone_enabled);



/**

 * rsi_dbg() - This function outputs informational messages.

 * @zone: Zone of interest for output message.

 * @fmt: printf-style format for output message.

 *

 * Return: none

 */

void rsi_dbg(u32 zone, const char *fmt, ...)

{

	struct va_format vaf;

	va_list args;



	va_start(args, fmt);



	vaf.fmt = fmt;

	vaf.va = &args;



	if (zone & rsi_zone_enabled)

		pr_info("%pV", &vaf);

	va_end(args);

}

EXPORT_SYMBOL_GPL(rsi_dbg);



/**

 * rsi_prepare_skb() - This function prepares the skb.

 * @common: Pointer to the driver private structure.

drivers/net/wireless/rsi/rsi_main.h

+1 −15
Original line number Diff line number Diff line
@@ -40,21 +40,7 @@ 
#define FSM_MAC_INIT_DONE               6



extern u32 rsi_zone_enabled;



static inline void rsi_dbg(u32 zone, const char *fmt, ...)

{

	struct va_format vaf;

	va_list args;



	va_start(args, fmt);



	vaf.fmt = fmt;

	vaf.va = &args;



	if (zone & rsi_zone_enabled)

		pr_info("%pV", &vaf);

	va_end(args);

}

extern void rsi_dbg(u32 zone, const char *fmt, ...);



#define RSI_MAX_VIFS                    1

#define NUM_EDCA_QUEUES                 4