Commit 2dce81bf authored Apr 30, 2008 by Oleg Nesterov Committed by Linus Torvalds Apr 30, 2008

signals: cleanup the usage of print_fatal_signal()



Move the callsite of print_fatal_signal() down, under "if
(sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.

We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 34c8f07b

kernel/signal.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1787,9 +1787,10 @@ relock:
		* Anything else is fatal, maybe with a core dump.
		*/
		current->flags \|= PF_SIGNALED;
		if ((signr != SIGKILL) && print_fatal_signals)
		print_fatal_signal(regs, signr);

		if (sig_kernel_coredump(signr)) {
		if (print_fatal_signals)
		print_fatal_signal(regs, signr);
		/*
		* If it was able to dump core, this kills all
		* other threads in the group and synchronizes with