Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d3c995e authored by Jann Horn's avatar Jann Horn Committed by Gerrit - the friendly Code Review server
Browse files

sched: panic on corrupted stack end 



Until now, hitting this BUG_ON caused a recursive oops (because oops
handling involves do_exit(), which calls into the scheduler, which in
turn raises an oops), which caused stuff below the stack to be
overwritten until a panic happened (e.g.  via an oops in interrupt
context, caused by the overwritten CPU index in the thread_info).

Just panic directly.

Conflicts:
	kernel/sched/core.c

Signed-off-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarDennis Cagle <d-cagle@codeaurora.org>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git
Git-commit: 29d6455178a09e1dc340380c582b13356227e8df
(cherry picked from commit 29d6455178a09e1dc340380c582b13356227e8df)
Change-Id: I73409be3e4cfba82bae36a487227eb5260cd6e37
parent 3c19f061

kernel/sched/core.c

+2 −1
Original line number Diff line number Diff line
@@ -6158,7 +6158,8 @@ static noinline void __schedule_bug(struct task_struct *prev) 
static inline void schedule_debug(struct task_struct *prev)

{

#ifdef CONFIG_SCHED_STACK_END_CHECK

	BUG_ON(unlikely(task_stack_end_corrupted(prev)));

	if (unlikely(task_stack_end_corrupted(prev)))

		panic("corrupted stack end detected inside scheduler\n");

#endif

	/*

	 * Test if we are atomic. Since do_exit() needs to call into