Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c9c8f36 authored by Benny Halevy's avatar Benny Halevy Committed by J. Bruce Fields
Browse files

NFSD: fix decode_cb_sequence4resok 



Fix bug introduced in patch
85a56480 NFSD: Update XDR decoders in NFSv4 callback client

Although decode_cb_sequence4resok ignores highest slotid and target highest slotid
it must account for their space in their xdr stream when calling xdr_inline_decode

Cc: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 47c85291

fs/nfsd/nfs4callback.c

+1 −1
Original line number Diff line number Diff line
@@ -432,7 +432,7 @@ static int decode_cb_sequence4resok(struct xdr_stream *xdr, 
	 * If the server returns different values for sessionID, slotID or

	 * sequence number, the server is looney tunes.

	 */

	p = xdr_inline_decode(xdr, NFS4_MAX_SESSIONID_LEN + 4 + 4);

	p = xdr_inline_decode(xdr, NFS4_MAX_SESSIONID_LEN + 4 + 4 + 4 + 4);

	if (unlikely(p == NULL))

		goto out_overflow;

	memcpy(id.data, p, NFS4_MAX_SESSIONID_LEN);