Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2c30aba2 authored by Dan Carpenter's avatar Dan Carpenter Committed by Tomi Valkeinen
Browse files

fbmem: return -EFAULT on copy_to_user() failure 



copy_to_user() returns the number of bytes remaining to be copied.
put_user() returns -EFAULT on error.

This function ORs a bunch of stuff together and returns jumbled non-zero
values on error.  It should return -EFAULT.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
parent 72e5512a

drivers/video/fbmem.c

+3 −1
Original line number Diff line number Diff line
@@ -1305,7 +1305,9 @@ static int do_fscreeninfo_to_user(struct fb_fix_screeninfo *fix, 
	err |= copy_to_user(fix32->reserved, fix->reserved,

			    sizeof(fix->reserved));



	return err;

	if (err)

		return -EFAULT;

	return 0;

}



static int fb_get_fscreeninfo(struct fb_info *info, unsigned int cmd,