Commit 2c166da7 authored Dec 20, 2016 by Jordan Crouse Committed by Greg Kroah-Hartman Aug 11, 2017

drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set




[ Upstream commit a6cb3b864b21b7345f824a4faa12b723c8aaf099 ]

For every submission buffer object one of MSM_SUBMIT_BO_WRITE
and MSM_SUBMIT_BO_READ must be set (and nothing else). If we
allowed zero then the buffer object would never get queued to
be unreferenced.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6a077768

drivers/gpu/drm/msm/msm_gem_submit.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,8 @@ static int submit_lookup_objects(struct msm_gem_submit *submit,
		pagefault_disable();
		}

		if (submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) {
		if ((submit_bo.flags & ~MSM_SUBMIT_BO_FLAGS) \|\|
		!(submit_bo.flags & MSM_SUBMIT_BO_FLAGS)) {
		DRM_ERROR("invalid flags: %x\n", submit_bo.flags);
		ret = -EINVAL;
		goto out_unlock;