Commit 2bcbe4c1 authored Sep 10, 2008 by Chris Adams Committed by Greg Kroah-Hartman Sep 23, 2008

usb serial: ti_usb_3410_5052 obviously broken by firmware changes



While making some other changes to ti_usb_3410_5052, I noticed that the
changes made to move the firmware loading to a separate function are
broken (in ti_download_firmware(), status is set to -ENOMEM and never
changed).  This means the driver will never initialize the device
properly.  It looks like status was supposed to get the result of
ti_do_download().

Signed-off-by: Chris Adams <cmadams@hiwaay.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 6ef65a7f

drivers/usb/serial/ti_usb_3410_5052.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1744,7 +1744,7 @@ static int ti_download_firmware(struct ti_device *tdev, int type)
		if (buffer) {
		memcpy(buffer, fw_p->data, fw_p->size);
		memset(buffer + fw_p->size, 0xff, buffer_size - fw_p->size);
		ti_do_download(dev, pipe, buffer, fw_p->size);
		status = ti_do_download(dev, pipe, buffer, fw_p->size);
		kfree(buffer);
		}
		release_firmware(fw_p);