Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ba58894 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (10544): v4l2-common: add comments warning that about the sort order 



Control arrays as are used with v4l2_ctrl_next must be sorted from
low to high. Add a comment at the top of all such arrays to warn
about this.

Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 1b6f1d96

drivers/media/video/cx18/cx18-controls.c

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ 
#include "cx18-mailbox.h"

#include "cx18-controls.h"



/* Must be sorted from low to high control ID! */

static const u32 user_ctrls[] = {

	V4L2_CID_USER_CLASS,

	V4L2_CID_BRIGHTNESS,

drivers/media/video/cx2341x.c

+1 −0
Original line number Diff line number Diff line
@@ -38,6 +38,7 @@ static int debug; 
module_param(debug, int, 0644);

MODULE_PARM_DESC(debug, "Debug level (0-1)");



/* Must be sorted from low to high control ID! */

const u32 cx2341x_mpeg_ctrls[] = {

	V4L2_CID_MPEG_CLASS,

	V4L2_CID_MPEG_STREAM_TYPE,

drivers/media/video/cx23885/cx23885-video.c

+1 −0
Original line number Diff line number Diff line
@@ -244,6 +244,7 @@ static struct cx23885_ctrl cx23885_ctls[] = { 
};

static const int CX23885_CTLS = ARRAY_SIZE(cx23885_ctls);



/* Must be sorted from low to high control ID! */

static const u32 cx23885_user_ctrls[] = {

	V4L2_CID_USER_CLASS,

	V4L2_CID_BRIGHTNESS,

drivers/media/video/cx88/cx88-video.c

+1 −0
Original line number Diff line number Diff line
@@ -298,6 +298,7 @@ static struct cx88_ctrl cx8800_ctls[] = { 
};

static const int CX8800_CTLS = ARRAY_SIZE(cx8800_ctls);



/* Must be sorted from low to high control ID! */

const u32 cx88_user_ctrls[] = {

	V4L2_CID_USER_CLASS,

	V4L2_CID_BRIGHTNESS,

drivers/media/video/ivtv/ivtv-controls.c

+1 −0
Original line number Diff line number Diff line
@@ -26,6 +26,7 @@ 
#include "ivtv-mailbox.h"

#include "ivtv-controls.h"



/* Must be sorted from low to high control ID! */

static const u32 user_ctrls[] = {

	V4L2_CID_USER_CLASS,

	V4L2_CID_BRIGHTNESS,