Commit 2b932d8e authored Jan 20, 2014 by David Herrmann

drm/udl: fix Bpp calculation in dumb_create()



Probably a typo.. we obviously need "(bpp + 7) / 8" instead of
"(bpp + 1) / 8". Unlikely to be hit in any sane code, but lets be safe.
Use DIV_ROUND_UP() to avoid the problem entirely and make the core more
readable.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: David Herrmann <dh.herrmann@gmail.com>

parent 06c99161

drivers/gpu/drm/udl/udl_gem.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -60,7 +60,7 @@ int udl_dumb_create(struct drm_file *file,
		struct drm_device *dev,
		struct drm_mode_create_dumb *args)
		{
		args->pitch = args->width * ((args->bpp + 1) / 8);
		args->pitch = args->width * DIV_ROUND_UP(args->bpp, 8);
		args->size = args->pitch * args->height;
		return udl_gem_create(file, dev,
		args->size, &args->handle);