Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b56f1c1 authored by Alan Jenkins's avatar Alan Jenkins Committed by Len Brown
Browse files

eeepc-laptop: fix led initialization order 



Create the workqueue thread used by tpd_led_set() *before* we register
the led device.  (And vice versa for unregistration).

Signed-off-by: default avatarAlan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent 48718688

drivers/platform/x86/eeepc-laptop.c

+6 −6
Original line number Diff line number Diff line
@@ -1074,10 +1074,10 @@ static void eeepc_hwmon_exit(void) 


static void eeepc_led_exit(void)

{

	if (led_workqueue)

		destroy_workqueue(led_workqueue);

	if (tpd_led.dev)

		led_classdev_unregister(&tpd_led);

	if (led_workqueue)

		destroy_workqueue(led_workqueue);

}



static int eeepc_new_rfkill(struct rfkill **rfkill,
@@ -1243,14 +1243,14 @@ static int eeepc_led_init(struct device *dev) 
	if (get_acpi(CM_ASL_TPD) == -ENODEV)

		return 0;



	rv = led_classdev_register(dev, &tpd_led);

	if (rv)

		return rv;



	led_workqueue = create_singlethread_workqueue("led_workqueue");

	if (!led_workqueue)

		return -ENOMEM;



	rv = led_classdev_register(dev, &tpd_led);

	if (rv)

		return rv;



	return 0;

}