Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b50b8f5 authored by Thomas Meyer's avatar Thomas Meyer Committed by John W. Linville
Browse files

iwlegacy: Use kcalloc instead of kzalloc to allocate array 

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: default avatarThomas Meyer <thomas@m3y3r.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 839fafbe

drivers/net/wireless/iwlegacy/common.c

+2 −3
Original line number Diff line number Diff line
@@ -2786,8 +2786,7 @@ il_tx_queue_alloc(struct il_priv *il, struct il_tx_queue *txq, u32 id) 
	/* Driver ilate data, only for Tx (not command) queues,

	 * not shared with device. */

	if (id != il->cmd_queue) {

		txq->txb =

		    kzalloc(sizeof(txq->txb[0]) * TFD_QUEUE_SIZE_MAX,

		txq->txb = kcalloc(TFD_QUEUE_SIZE_MAX, sizeof(txq->txb[0]),

				   GFP_KERNEL);

		if (!txq->txb) {

			IL_ERR("kmalloc for auxiliary BD "