Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b3f291b authored by Sathya Perla's avatar Sathya Perla Committed by David S. Miller
Browse files

be2net: fix certain cmd failure logging 



Some (older)versions of cards/fw may not recognize certain cmds and
return illegal/unsupported errors. As long as the driver can handle
this gracefully there is no need to log an error msg.
Also finetuned 2 existing error log messages.

Signed-off-by: default avatarSathya Perla <sathya.perla@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e1428d26

drivers/net/benet/be_cmds.c

+17 −7
Original line number Diff line number Diff line
@@ -106,14 +106,24 @@ static int be_mcc_compl_process(struct be_adapter *adapter, 
			netdev_stats_update(adapter);

			adapter->stats_cmd_sent = false;

		}

	} else if ((compl_status != MCC_STATUS_NOT_SUPPORTED) &&

		   (compl->tag0 != OPCODE_COMMON_NTWK_MAC_QUERY)) {

	} else {

		if (compl_status == MCC_STATUS_NOT_SUPPORTED ||

			compl_status == MCC_STATUS_ILLEGAL_REQUEST)

			goto done;



		if (compl_status == MCC_STATUS_UNAUTHORIZED_REQUEST) {

			dev_warn(&adapter->pdev->dev, "This domain(VM) is not "

				"permitted to execute this cmd (opcode %d)\n",

				compl->tag0);

		} else {

			extd_status = (compl->status >> CQE_STATUS_EXTD_SHIFT) &

					CQE_STATUS_EXTD_MASK;

		dev_warn(&adapter->pdev->dev,

		"Error in cmd completion - opcode %d, compl %d, extd %d\n",

			dev_err(&adapter->pdev->dev, "Cmd (opcode %d) failed:"

				"status %d, extd-status %d\n",

				compl->tag0, compl_status, extd_status);

		}

	}

done:

	return compl_status;

}

drivers/net/benet/be_cmds.h

+6 −11
Original line number Diff line number Diff line
@@ -51,17 +51,12 @@ struct be_mcc_wrb { 


/* Completion Status */

enum {

	MCC_STATUS_SUCCESS = 0x0,

/* The client does not have sufficient privileges to execute the command */

	MCC_STATUS_INSUFFICIENT_PRIVILEGES = 0x1,

/* A parameter in the command was invalid. */

	MCC_STATUS_INVALID_PARAMETER = 0x2,

/* There are insufficient chip resources to execute the command */

	MCC_STATUS_INSUFFICIENT_RESOURCES = 0x3,

/* The command is completing because the queue was getting flushed */

	MCC_STATUS_QUEUE_FLUSHING = 0x4,

/* The command is completing with a DMA error */

	MCC_STATUS_DMA_FAILED = 0x5,

	MCC_STATUS_SUCCESS = 0,

	MCC_STATUS_FAILED = 1,

	MCC_STATUS_ILLEGAL_REQUEST = 2,

	MCC_STATUS_ILLEGAL_FIELD = 3,

	MCC_STATUS_INSUFFICIENT_BUFFER = 4,

	MCC_STATUS_UNAUTHORIZED_REQUEST = 5,

	MCC_STATUS_NOT_SUPPORTED = 66

};