Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b1afa87 authored by Auke Kok's avatar Auke Kok Committed by Greg Kroah-Hartman
Browse files

PCI: quirk_vialatency: Omit reading pci revision ID 



Don't read the revision ID unnecessary since the PCI subsystem
fills this field in already.

Updated to fix a thinko bug in a previously sent patch.

Signed-off-by: default avatarAuke Kok <auke-jan.h.kok@intel.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 561e55e8

drivers/pci/quirks.c

+2 −5
Original line number Diff line number Diff line
@@ -139,25 +139,22 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82439TX, quir 
static void quirk_vialatency(struct pci_dev *dev)

{

	struct pci_dev *p;

	u8 rev;

	u8 busarb;

	/* Ok we have a potential problem chipset here. Now see if we have

	   a buggy southbridge */

	   

	p = pci_get_device(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, NULL);

	if (p!=NULL) {

		pci_read_config_byte(p, PCI_CLASS_REVISION, &rev);

		/* 0x40 - 0x4f == 686B, 0x10 - 0x2f == 686A; thanks Dan Hollis */

		/* Check for buggy part revisions */

		if (rev < 0x40 || rev > 0x42)

		if (p->revision < 0x40 || p->revision > 0x42)

			goto exit;

	} else {

		p = pci_get_device(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8231, NULL);

		if (p==NULL)	/* No problem parts */

			goto exit;

		pci_read_config_byte(p, PCI_CLASS_REVISION, &rev);

		/* Check for buggy part revisions */

		if (rev < 0x10 || rev > 0x12) 

		if (p->revision < 0x10 || p->revision > 0x12)

			goto exit;

	}