Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2b09ce98 authored by Bob Moore's avatar Bob Moore Committed by Len Brown
Browse files

ACPICA: Fix implementation of AML BreakPoint operator (break to debugger) 



The AML BreakPoint opcode will now cause a break into the AML
debugger if it is present/configured. This matches the expected
behavior per the ACPI specification. Previously, only a message
was output.

Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLin Ming <ming.m.lin@intel.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent ba9c3f55

drivers/acpi/acpica/dsopcode.c

+11 −6
Original line number Diff line number Diff line
@@ -1386,14 +1386,19 @@ acpi_ds_exec_end_control_op(struct acpi_walk_state * walk_state, 


	case AML_BREAK_POINT_OP:



		/* Call up to the OS service layer to handle this */



		status =

		    acpi_os_signal(ACPI_SIGNAL_BREAKPOINT,

				   "Executed AML Breakpoint opcode");

		/*

		 * Set the single-step flag. This will cause the debugger (if present)

		 * to break to the console within the AML debugger at the start of the

		 * next AML instruction.

		 */

		ACPI_DEBUGGER_EXEC(acpi_gbl_cm_single_step = TRUE);

		ACPI_DEBUGGER_EXEC(acpi_os_printf

				   ("**break** Executed AML BreakPoint opcode\n"));



		/* If and when it returns, all done. */

		/* Call to the OSL in case OS wants a piece of the action */



		status = acpi_os_signal(ACPI_SIGNAL_BREAKPOINT,

					"Executed AML Breakpoint opcode");

		break;



	case AML_BREAK_OP: