Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a5cac17 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

fs/ncpfs/inode.c: suppress used-uninitialised warning 



We get this spurious warning:

  fs/ncpfs/inode.c: In function 'ncp_fill_super':
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[1u]' may be used uninitialized in this function
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[2u]' may be used uninitialized in this function
  fs/ncpfs/inode.c:451: warning: 'data.mounted_vol[3u]' may be used uninitialized in this function
  ...

It's notabug, but we can easily fix it with a memset().

Reported-by: default avatarHarry Wei <jiaweiwei.xiyou@gmail.com>
Cc: Petr Vandrovec <petr@vandrovec.name>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0fccc622

fs/ncpfs/inode.c

+1 −3
Original line number Diff line number Diff line
@@ -461,7 +461,7 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
#endif

	struct ncp_entry_info finfo;



	data.wdog_pid = NULL;

	memset(&data, 0, sizeof(data));

	server = kzalloc(sizeof(struct ncp_server), GFP_KERNEL);

	if (!server)

		return -ENOMEM;
@@ -496,7 +496,6 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
				struct ncp_mount_data_v4* md = (struct ncp_mount_data_v4*)raw_data;



				data.flags = md->flags;

				data.int_flags = 0;

				data.mounted_uid = md->mounted_uid;

				data.wdog_pid = find_get_pid(md->wdog_pid);

				data.ncp_fd = md->ncp_fd;
@@ -507,7 +506,6 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) 
				data.file_mode = md->file_mode;

				data.dir_mode = md->dir_mode;

				data.info_fd = -1;

				data.mounted_vol[0] = 0;

			}

			break;

		default: