Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a211f32 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Greg Kroah-Hartman
Browse files

thunderbolt: Use kcalloc 



The advantage of kcalloc is, that will prevent integer overflows
which could result from the multiplication of number of elements
and size and it is also a bit nicer to read.

Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Acked-by: default avatarAndreas Noever <andreas.noever@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 95b4ecbf

drivers/thunderbolt/nhi.c

+4 −6
Original line number Diff line number Diff line
@@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) 
			 nhi->hop_count);

	INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);



	nhi->tx_rings = devm_kzalloc(&pdev->dev,

				     nhi->hop_count * sizeof(*nhi->tx_rings),

				     GFP_KERNEL);

	nhi->rx_rings = devm_kzalloc(&pdev->dev,

				     nhi->hop_count * sizeof(*nhi->rx_rings),

				     GFP_KERNEL);

	nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,

				     sizeof(*nhi->tx_rings), GFP_KERNEL);

	nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,

				     sizeof(*nhi->rx_rings), GFP_KERNEL);

	if (!nhi->tx_rings || !nhi->rx_rings)

		return -ENOMEM;