Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 296cb3ff authored by Mitchel Humpherys's avatar Mitchel Humpherys
Browse files

iommu/arm-smmu: Rate-limit the context fault handler 



It's not uncommon for us to take a flood of context faults when
something terrible happens.  This usually brings down the system due to
excessive logging, which makes it difficult to debug the actual root
cause of the issue.  Fix this by rate-limiting the output from the
context fault handler.

Change-Id: I1fe83bbbc7cc7aa2cf6303c6c7d2bf5733f63557
Signed-off-by: default avatarMitchel Humpherys <mitchelh@codeaurora.org>
parent 9d19a050

drivers/iommu/arm-smmu.c

+28 −19
Original line number Diff line number Diff line
@@ -1089,6 +1089,10 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) 
	phys_addr_t phys_soft;

	u32 frsynra;



	static DEFINE_RATELIMIT_STATE(_rs,

				      DEFAULT_RATELIMIT_INTERVAL,

				      DEFAULT_RATELIMIT_BURST);



	mutex_lock(&smmu_domain->init_mutex);

	smmu = smmu_domain->smmu;

	if (!smmu) {
@@ -1148,11 +1152,15 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) 
		phys_addr_t phys_atos = arm_smmu_verify_fault(domain, iova,

							      fsr);



		if (__ratelimit(&_rs)) {

			dev_err(smmu->dev,

				"Unhandled context fault: iova=0x%08lx, fsr=0x%x, fsynr=0x%x, cb=%d\n",

				iova, fsr, fsynr, cfg->cbndx);

		dev_err(smmu->dev, "FAR    = %016lx\n", (unsigned long)far);

		dev_err(smmu->dev, "FSR    = %08x [%s%s%s%s%s%s%s%s%s]\n", fsr,

			dev_err(smmu->dev, "FAR    = %016lx\n",

				(unsigned long)far);

			dev_err(smmu->dev,

				"FSR    = %08x [%s%s%s%s%s%s%s%s%s]\n",

				fsr,

				(fsr & 0x02) ? "TF " : "",

				(fsr & 0x04) ? "AFF " : "",

				(fsr & 0x08) ? "PF " : "",
@@ -1167,6 +1175,7 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) 
			dev_err(smmu->dev,

				"hard iova-to-phys (ATOS)=%pa\n", &phys_atos);

			dev_err(smmu->dev, "SID=0x%x\n", frsynra & 0x1FF);

		}

		ret = IRQ_NONE;

		resume = RESUME_TERMINATE;

	}