Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2920ee2b authored by Steve French's avatar Steve French
Browse files

[CIFS] potential NULL dereference in parse_DFS_referrals() 



memory allocation may fail, prevent a NULL dereference

Pointed out by Roel Kluin

CC: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 7b2aa037

fs/cifs/cifssmb.c

+4 −0
Original line number Diff line number Diff line
@@ -3961,6 +3961,10 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr, 
		if (is_unicode) {

			__le16 *tmp = kmalloc(strlen(searchName)*2 + 2,

						GFP_KERNEL);

			if (tmp == NULL) {

				rc = -ENOMEM;

				goto parse_DFS_referrals_exit;

			}

			cifsConvertToUCS((__le16 *) tmp, searchName,

					PATH_MAX, nls_codepage, remap);

			node->path_consumed = cifs_ucs2_bytes(tmp,