Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28f39ef6 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

tulip: cleanup by using ARRAY_SIZE() 



In this situation then ARRAY_SIZE() and sizeof() are the same, but we're
really dealing with array indexes and not byte offsets so ARRAY_SIZE()
is cleaner.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarGrant Grundler <grundler@parisc-linux.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 11c21a30

drivers/net/ethernet/dec/tulip/media.c

+1 −1
Original line number Diff line number Diff line
@@ -457,7 +457,7 @@ void tulip_find_mii(struct net_device *dev, int board_idx) 
	/* Find the connected MII xcvrs.

	   Doing this in open() would allow detecting external xcvrs later,

	   but takes much time. */

	for (phyn = 1; phyn <= 32 && phy_idx < sizeof (tp->phys); phyn++) {

	for (phyn = 1; phyn <= 32 && phy_idx < ARRAY_SIZE(tp->phys); phyn++) {

		int phy = phyn & 0x1f;

		int mii_status = tulip_mdio_read (dev, phy, MII_BMSR);

		if ((mii_status & 0x8301) == 0x8001 ||