Commit 28bdc499 authored Mar 19, 2014 by Sergei Shtylyov Committed by David S. Miller Mar 19, 2014

micrel: fix masking off LED bits



Commit 20d8435a (phy: micrel: add of configuration for LED mode) made the
obvious mistake when masking off  the LED mode bits: forgot to do a logical NOT
to the mask with which it ANDs the register value, so that unrelated bits are
cleared instead.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3ab428a4

drivers/net/phy/micrel.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -167,7 +167,7 @@ static int kszphy_setup_led(struct phy_device *phydev,
		if (temp < 0)
		return temp;

		temp &= 3 << shift;
		temp &= ~(3 << shift);
		temp \|= val << shift;
		rc = phy_write(phydev, reg, temp);