Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2875fb65 authored by Ingo van Lil's avatar Ingo van Lil Committed by Linus Torvalds
Browse files

mtd: memory corruption in block2mtd.c



The block2mtd driver (drivers/mtd/devices/block2mtd.c) will kfree an on-stack
pointer when handling an invalid argument line (e.g.
block2mtd=/dev/loop0,xxx).

The kfree was added some time ago when "name" was dynamically allocated.

Signed-off-by: default avatarIngo van Lil <inguin@gmx.de>
Acked-by: default avatarJoern Engel <joern@lazybastard.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: <stable@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1312848e
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -408,7 +408,6 @@ static int block2mtd_setup2(const char *val)
	if (token[1]) {
		ret = parse_num(&erase_size, token[1]);
		if (ret) {
			kfree(name);
			parse_err("illegal erase size");
		}
	}