Commit 286f8f3c authored Nov 27, 2011 by NeilBrown Committed by Samuel Ortiz Dec 20, 2011

mfd: Base interrupt for twl4030-irq must be one-shot



As the interrupt source is only cleared by the threaded interrupt
service routine, we need to make the base interrupt IRQF_ONESHOT.
Without this, the first interrupt from the TWL4030 cause the CPU to
enter an infinite loop trying to handle to interrupt but never
clearing it.

Signed-off-by: NeilBrown <neilb@suse.de>
Tested-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent 8f6a459a

drivers/mfd/twl4030-irq.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -733,7 +733,8 @@ int twl4030_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
		}

		/* install an irq handler to demultiplex the TWL4030 interrupt */
		status = request_threaded_irq(irq_num, NULL, handle_twl4030_pih, 0,
		status = request_threaded_irq(irq_num, NULL, handle_twl4030_pih,
		IRQF_ONESHOT,
		"TWL4030-PIH", NULL);
		if (status < 0) {
		pr_err("twl4030: could not claim irq%d: %d\n", irq_num, status);