Commit 2812452c authored May 09, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Apr 13, 2018

netxen_nic: set rcode to the return status from the call to netxen_issue_cmd




[ Upstream commit 0fe20fafd1791f993806d417048213ec57b81045 ]

Currently rcode is being initialized to NX_RCODE_SUCCESS and later it
is checked to see if it is not NX_RCODE_SUCCESS which is never true. It
appears that there is an unintentional missing assignment of rcode from
the return of the call to netxen_issue_cmd() that was dropped in
an earlier fix, so add it in.

Detected by CoverityScan, CID#401900 ("Logically dead code")

Fixes: 2dcd5d95 ("netxen_nic: fix cdrp race condition")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4db93645

drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -247,7 +247,7 @@ nx_fw_cmd_set_mtu(struct netxen_adapter *adapter, int mtu)
	cmd.req.arg3 = 0;		cmd.req.arg3 = 0;

	if (recv_ctx->state == NX_HOST_CTX_STATE_ACTIVE)		if (recv_ctx->state == NX_HOST_CTX_STATE_ACTIVE)
	netxen_issue_cmd(adapter, &cmd);		rcode = netxen_issue_cmd(adapter, &cmd);

	if (rcode != NX_RCODE_SUCCESS)		if (rcode != NX_RCODE_SUCCESS)
	return -EIO;		return -EIO;