Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27b1b228 authored by Andi Shyti's avatar Andi Shyti Committed by Theodore Ts'o
Browse files

ext4: fix use of potentially uninitialized variables in debugging code 



If ext_debugging is enabled and path[depth].p_ext is NULL, len
and lblock are printed non initialized

Signed-off-by: default avatarAndi Shyti <andi@etezian.org>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 90e775b7

fs/ext4/extents.c

+2 −3
Original line number Diff line number Diff line
@@ -2285,8 +2285,8 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path, 
				ext4_lblk_t block)

{

	int depth = ext_depth(inode);

	unsigned long len;

	ext4_lblk_t lblock;

	unsigned long len = 0;

	ext4_lblk_t lblock = 0;

	struct ext4_extent *ex;



	ex = path[depth].p_ext;
@@ -2323,7 +2323,6 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path, 
			ext4_es_insert_extent(inode, lblock, len, ~0,

					      EXTENT_STATUS_HOLE);

	} else {

		lblock = len = 0;

		BUG();

	}