Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27712b39 authored by Pavan Savoy's avatar Pavan Savoy Committed by Greg Kroah-Hartman
Browse files

drivers/misc/ti-st: remove sparse warnings 



remove sparse warnings by assigning right storage specifiers to functions and
also clean-up the declarations in the include/linux/ti_wilink_st.h

Signed-off-by: default avatarPavan Savoy <pavan_savoy@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent eccf2979

drivers/misc/ti-st/st_core.c

+7 −5
Original line number Diff line number Diff line
@@ -30,11 +30,13 @@ 


#include <linux/ti_wilink_st.h>



extern void st_kim_recv(void *, const unsigned char *, long);

void st_int_recv(void *, const unsigned char *, long);

/* function pointer pointing to either,

 * st_kim_recv during registration to receive fw download responses

 * st_int_recv after registration to receive proto stack responses

 */

void (*st_recv) (void*, const unsigned char*, long);

static void (*st_recv) (void *, const unsigned char *, long);



/********************************************************************/

static void add_channel_to_table(struct st_data_s *st_gdata,
@@ -100,7 +102,7 @@ int st_int_write(struct st_data_s *st_gdata, 
 * push the skb received to relevant

 * protocol stacks

 */

void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata)

static void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata)

{

	pr_debug(" %s(prot:%d) ", __func__, chnl_id);
@@ -140,7 +142,7 @@ void st_send_frame(unsigned char chnl_id, struct st_data_s *st_gdata) 
 * This function is being called with spin lock held, protocol drivers are

 * only expected to complete their waits and do nothing more than that.

 */

void st_reg_complete(struct st_data_s *st_gdata, char err)

static void st_reg_complete(struct st_data_s *st_gdata, char err)

{

	unsigned char i = 0;

	pr_info(" %s ", __func__);
@@ -379,7 +381,7 @@ done: 
 *	completely, return that skb which has the pending data.

 *	In normal cases, return top of txq.

 */

struct sk_buff *st_int_dequeue(struct st_data_s *st_gdata)

static struct sk_buff *st_int_dequeue(struct st_data_s *st_gdata)

{

	struct sk_buff *returning_skb;
@@ -401,7 +403,7 @@ struct sk_buff *st_int_dequeue(struct st_data_s *st_gdata) 
 *	txq and waitq needs protection since the other contexts

 *	may be sending data, waking up chip.

 */

void st_int_enqueue(struct st_data_s *st_gdata, struct sk_buff *skb)

static void st_int_enqueue(struct st_data_s *st_gdata, struct sk_buff *skb)

{

	unsigned long flags = 0;

drivers/misc/ti-st/st_kim.c

+6 −6
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ static struct platform_device *st_get_plat_device(int id) 
 *	in case of error don't complete so that waiting for proper

 *	response times out

 */

void validate_firmware_response(struct kim_data_s *kim_gdata)

static void validate_firmware_response(struct kim_data_s *kim_gdata)

{

	struct sk_buff *skb = kim_gdata->rx_skb;

	if (unlikely(skb->data[5] != 0)) {
@@ -119,7 +119,7 @@ static inline int kim_check_data_len(struct kim_data_s *kim_gdata, int len) 
 *	have been observed to come in bursts of different

 *	tty_receive and hence the logic

 */

void kim_int_recv(struct kim_data_s *kim_gdata,

static void kim_int_recv(struct kim_data_s *kim_gdata,

	const unsigned char *data, long count)

{

	const unsigned char *ptr;
@@ -236,7 +236,7 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name) 
	return 0;

}



void skip_change_remote_baud(unsigned char **ptr, long *len)

static void skip_change_remote_baud(unsigned char **ptr, long *len)

{

	unsigned char *nxt_action, *cur_action;

	cur_action = *ptr;
@@ -688,7 +688,7 @@ static const struct file_operations list_debugfs_fops = { 
 * board-*.c file

 */



struct dentry *kim_debugfs_dir;

static struct dentry *kim_debugfs_dir;

static int kim_probe(struct platform_device *pdev)

{

	long status;
@@ -769,7 +769,7 @@ static int kim_remove(struct platform_device *pdev) 
	return 0;

}



int kim_suspend(struct platform_device *pdev, pm_message_t state)

static int kim_suspend(struct platform_device *pdev, pm_message_t state)

{

	struct ti_st_plat_data	*pdata = pdev->dev.platform_data;
@@ -779,7 +779,7 @@ int kim_suspend(struct platform_device *pdev, pm_message_t state) 
	return -EOPNOTSUPP;

}



int kim_resume(struct platform_device *pdev)

static int kim_resume(struct platform_device *pdev)

{

	struct ti_st_plat_data	*pdata = pdev->dev.platform_data;

include/linux/ti_wilink_st.h

+2 −1
Original line number Diff line number Diff line
@@ -281,9 +281,10 @@ struct kim_data_s { 
long st_kim_start(void *);

long st_kim_stop(void *);



void st_kim_recv(void *, const unsigned char *, long count);

void st_kim_complete(void *);

void kim_st_list_protocols(struct st_data_s *, void *);

void st_kim_recv(void *, const unsigned char *, long);





/*

 * BTS headers