Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 272bfbd5 authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

spi: fix return value check in dspi_probe() 



In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 57873925

drivers/spi/spi-fsl-dspi.c

+2 −8
Original line number Diff line number Diff line
@@ -476,15 +476,9 @@ static int dspi_probe(struct platform_device *pdev) 
	master->bus_num = bus_num;



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res) {

		dev_err(&pdev->dev, "can't get platform resource\n");

		ret = -EINVAL;

		goto out_master_put;

	}



	dspi->base = devm_ioremap_resource(&pdev->dev, res);

	if (!dspi->base) {

		ret = -EINVAL;

	if (IS_ERR(dspi->base)) {

		ret = PTR_ERR(dspi->base);

		goto out_master_put;

	}