Commit 26952669 authored Mar 03, 2009 by Roel Kluin Committed by Wim Van Sebroeck Mar 05, 2009

[WATCHDOG] gef_wdt.c: fsl_get_sys_freq() failure not noticed



fsl_get_sys_freq() may return -1 when 'soc' isn't found, but in
gef_wdt_probe() 'freq' is unsigned, so the test doesn't catch that.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

parent b02c3878

drivers/watchdog/gef_wdt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -269,7 +269,7 @@ static int __devinit gef_wdt_probe(struct of_device *dev,
		bus_clk = 133; /* in MHz */

		freq = fsl_get_sys_freq();
		if (freq > 0)
		if (freq != -1)
		bus_clk = freq;

		/* Map devices registers into memory */