Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26110dac authored by Michael Krufky's avatar Michael Krufky Committed by Mauro Carvalho Chehab
Browse files

[media] lgdt330x: fix behavior of read errors in lgdt330x_read_ucblocks 



initialize *ucblocks to zero & fix the following build warning:

lgdt330x.c: In function "lgdt330x_read_ucblocks":
lgdt330x.c:288:6: warning: variable "err" set but not used
[-Wunused-but-set-variable]

Signed-off-by: default avatarMichael Krufky <mkrufky@linuxtv.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 7e7b8287

drivers/media/dvb/frontends/lgdt330x.c

+4 −0
Original line number Diff line number Diff line
@@ -288,6 +288,8 @@ static int lgdt330x_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) 
	int err;

	u8 buf[2];



	*ucblocks = 0;



	switch (state->config->demod_chip) {

	case LGDT3302:

		err = i2c_read_demod_bytes(state, LGDT3302_PACKET_ERR_COUNTER1,
@@ -302,6 +304,8 @@ static int lgdt330x_read_ucblocks(struct dvb_frontend* fe, u32* ucblocks) 
		       "Only LGDT3302 and LGDT3303 are supported chips.\n");

		err = -ENODEV;

	}

	if (err < 0)

		return err;



	*ucblocks = (buf[0] << 8) | buf[1];

	return 0;