Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 246f2d2e authored by H. Peter Anvin's avatar H. Peter Anvin
Browse files

x86-32, espfix: Remove filter for espfix32 due to race



It is not safe to use LAR to filter when to go down the espfix path,
because the LDT is per-process (rather than per-thread) and another
thread might change the descriptors behind our back.  Fortunately it
is always *safe* (if a bit slow) to go down the espfix path, and a
32-bit LDT stack segment is extremely rare.

Signed-off-by: default avatarH. Peter Anvin <hpa@linux.intel.com>
Link: http://lkml.kernel.org/r/1398816946-3351-1-git-send-email-hpa@linux.intel.com
Cc: <stable@vger.kernel.org> # consider after upstream merge
parent 3891a04a
Loading
Loading
Loading
Loading
+0 −5
Original line number Diff line number Diff line
@@ -551,11 +551,6 @@ ENTRY(iret_exc)

	CFI_RESTORE_STATE
ldt_ss:
	larl PT_OLDSS(%esp), %eax
	jnz restore_nocheck
	testl $0x00400000, %eax		# returning to 32bit stack?
	jnz restore_nocheck		# allright, normal return

#ifdef CONFIG_PARAVIRT
	/*
	 * The kernel can't run on a non-flat stack if paravirt mode