Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23ee84dd authored by Deva Ramasubramanian's avatar Deva Ramasubramanian
Browse files

msm: vidc: General code clean up 



Fixed a few spots where there were namespace leaks (i.e. hfi_* stuff
appearing where they have no business appearing).  Also collapsed a few
lines of code that could easily fit into 80 chars to reduce SLOC.

Change-Id: I468e470a84445c16f12be142afe5433ca05e3e41
Signed-off-by: default avatarDeva Ramasubramanian <dramasub@codeaurora.org>
parent fd854d74

drivers/media/platform/msm/vidc/hfi_packetization.c

+17 −4
Original line number Diff line number Diff line
@@ -1745,7 +1745,7 @@ int create_pkt_cmd_session_set_property( 
			HFI_PROPERTY_PARAM_VDEC_SCS_THRESHOLD;

		hfi = (struct hfi_scs_threshold *) &pkt->rg_property_data[1];

		hfi->threshold_value =

			((struct hfi_scs_threshold *) pdata)->threshold_value;

			((struct hal_scs_threshold *) pdata)->threshold_value;

		pkt->size += sizeof(u32) + sizeof(struct hfi_scs_threshold);

		break;

	}
@@ -1882,9 +1882,22 @@ int create_pkt_cmd_session_set_property( 
	}

	case HAL_CONFIG_VENC_PERF_MODE:

	{

		pkt->rg_property_data[0] =

			HFI_PROPERTY_CONFIG_VENC_PERF_MODE;

		pkt->rg_property_data[1] = *(u32 *)pdata;

		u32 hfi_perf_mode = 0;

		enum hal_perf_mode hal_perf_mode = *(enum hal_perf_mode *)pdata;



		switch (hal_perf_mode) {

		case HAL_PERF_MODE_POWER_SAVE:

			hfi_perf_mode = HFI_VENC_PERFMODE_POWER_SAVE;

			break;

		case HAL_PERF_MODE_POWER_MAX_QUALITY:

			hfi_perf_mode = HFI_VENC_PERFMODE_MAX_QUALITY;

			break;

		default:

			return -ENOTSUPP;

		}



		pkt->rg_property_data[0] = HFI_PROPERTY_CONFIG_VENC_PERF_MODE;

		pkt->rg_property_data[1] = hfi_perf_mode;

		pkt->size += sizeof(u32) * 2;

		break;

	}

drivers/media/platform/msm/vidc/msm_vdec.c

+8 −15
Original line number Diff line number Diff line
@@ -2095,7 +2095,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	struct hal_extradata_enable extra;

	struct hal_buffer_alloc_mode alloc_mode;

	struct hal_multi_stream multi_stream;

	struct hfi_scs_threshold scs_threshold;

	struct hal_scs_threshold scs_threshold;

	struct hal_mvc_buffer_layout layout;

	struct v4l2_ctrl *temp_ctrl = NULL;

	struct hal_profile_level profile_level;
@@ -2129,10 +2129,8 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 


	switch (ctrl->id) {

	case V4L2_CID_MPEG_VIDC_VIDEO_STREAM_FORMAT:

		property_id =

		HAL_PARAM_NAL_STREAM_FORMAT_SELECT;

		stream_format.nal_stream_format_supported =

		(0x00000001 << ctrl->val);

		property_id = HAL_PARAM_NAL_STREAM_FORMAT_SELECT;

		stream_format.nal_stream_format_supported = BIT(ctrl->val);

		pdata = &stream_format;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_OUTPUT_ORDER:
@@ -2141,20 +2139,17 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		pdata = &property_val;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_ENABLE_PICTURE_TYPE:

		property_id =

			HAL_PARAM_VDEC_PICTURE_TYPE_DECODE;

		property_id = HAL_PARAM_VDEC_PICTURE_TYPE_DECODE;

		enable_picture.picture_type = ctrl->val;

		pdata = &enable_picture;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_KEEP_ASPECT_RATIO:

		property_id =

			HAL_PARAM_VDEC_OUTPUT2_KEEP_ASPECT_RATIO;

		property_id = HAL_PARAM_VDEC_OUTPUT2_KEEP_ASPECT_RATIO;

		hal_property.enable = ctrl->val;

		pdata = &hal_property;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_POST_LOOP_DEBLOCKER_MODE:

		property_id =

			HAL_CONFIG_VDEC_POST_LOOP_DEBLOCKER;

		property_id = HAL_CONFIG_VDEC_POST_LOOP_DEBLOCKER;

		hal_property.enable = ctrl->val;

		pdata = &hal_property;

		break;
@@ -2164,14 +2159,12 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		pdata = &property_val;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_MB_ERROR_MAP_REPORTING:

		property_id =

			HAL_CONFIG_VDEC_MB_ERROR_MAP_REPORTING;

		property_id = HAL_CONFIG_VDEC_MB_ERROR_MAP_REPORTING;

		hal_property.enable = ctrl->val;

		pdata = &hal_property;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_CONTINUE_DATA_TRANSFER:

		property_id =

			HAL_PARAM_VDEC_CONTINUE_DATA_TRANSFER;

		property_id = HAL_PARAM_VDEC_CONTINUE_DATA_TRANSFER;

		hal_property.enable = ctrl->val;

		pdata = &hal_property;

		break;

drivers/media/platform/msm/vidc/msm_venc.c

+23 −42
Original line number Diff line number Diff line
@@ -1883,7 +1883,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	struct hal_ltr_mark mark_ltr;

	struct hal_hybrid_hierp hyb_hierp;

	u32 hier_p_layers = 0, hier_b_layers = 0, mbi_statistics_mode = 0;

	struct hal_venc_perf_mode venc_mode;

	enum hal_perf_mode venc_mode;



	if (!inst || !inst->core || !inst->core->device) {

		dprintk(VIDC_ERR, "%s invalid parameters\n", __func__);
@@ -1921,8 +1921,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
			break;

		}



		property_id =

			HAL_CONFIG_VENC_IDR_PERIOD;

		property_id = HAL_CONFIG_VENC_IDR_PERIOD;

		idr_period.idr_period = ctrl->val;

		pdata = &idr_period;

		break;
@@ -1963,8 +1962,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		break;

	}

	case V4L2_CID_MPEG_VIDC_VIDEO_REQUEST_IFRAME:

		property_id =

			HAL_CONFIG_VENC_REQUEST_IFRAME;

		property_id = HAL_CONFIG_VENC_REQUEST_IFRAME;

		request_iframe.enable = true;

		pdata = &request_iframe;

		break;
@@ -2070,8 +2068,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		temp_ctrl = TRY_GET_CTRL(

			V4L2_CID_MPEG_VIDC_VIDEO_H264_CABAC_MODEL);



		property_id =

			HAL_PARAM_VENC_H264_ENTROPY_CONTROL;

		property_id = HAL_PARAM_VENC_H264_ENTROPY_CONTROL;

		h264_entropy_control.entropy_mode = venc_v4l2_to_hal(

			V4L2_CID_MPEG_VIDEO_H264_ENTROPY_MODE, ctrl->val);

		h264_entropy_control.cabac_model = venc_v4l2_to_hal(
@@ -2082,8 +2079,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDC_VIDEO_H264_CABAC_MODEL:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_ENTROPY_MODE);



		property_id =

			HAL_PARAM_VENC_H264_ENTROPY_CONTROL;

		property_id = HAL_PARAM_VENC_H264_ENTROPY_CONTROL;

		h264_entropy_control.cabac_model = venc_v4l2_to_hal(

			V4L2_CID_MPEG_VIDEO_H264_ENTROPY_MODE, ctrl->val);

		h264_entropy_control.entropy_mode = venc_v4l2_to_hal(
@@ -2094,8 +2090,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDEO_MPEG4_PROFILE:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_MPEG4_LEVEL);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.profile = venc_v4l2_to_hal(ctrl->id,

						ctrl->val);

		profile_level.level = venc_v4l2_to_hal(
@@ -2106,8 +2101,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDEO_MPEG4_LEVEL:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_MPEG4_PROFILE);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.level = venc_v4l2_to_hal(ctrl->id,

							ctrl->val);

		profile_level.profile = venc_v4l2_to_hal(
@@ -2118,8 +2112,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDEO_H264_PROFILE:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_LEVEL);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.profile = venc_v4l2_to_hal(ctrl->id,

							ctrl->val);

		profile_level.level = venc_v4l2_to_hal(
@@ -2132,8 +2125,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDEO_H264_LEVEL:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_PROFILE);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.level = venc_v4l2_to_hal(ctrl->id,

							ctrl->val);

		profile_level.profile = venc_v4l2_to_hal(
@@ -2146,8 +2138,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDC_VIDEO_H263_PROFILE:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDC_VIDEO_H263_LEVEL);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.profile = venc_v4l2_to_hal(ctrl->id,

							ctrl->val);

		profile_level.level = venc_v4l2_to_hal(
@@ -2158,8 +2149,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDC_VIDEO_H263_LEVEL:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDC_VIDEO_H263_PROFILE);



		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.level = venc_v4l2_to_hal(ctrl->id,

							ctrl->val);

		profile_level.profile = venc_v4l2_to_hal(
@@ -2168,8 +2158,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		pdata = &profile_level;

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_VP8_PROFILE_LEVEL:

		property_id =

			HAL_PARAM_PROFILE_LEVEL_CURRENT;

		property_id = HAL_PARAM_PROFILE_LEVEL_CURRENT;

		profile_level.profile = venc_v4l2_to_hal(

				V4L2_CID_MPEG_VIDC_VIDEO_VP8_PROFILE_LEVEL,

				ctrl->val);
@@ -2218,8 +2207,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
			rc = -EINVAL;

			break;

		}

		property_id =

			HAL_CONFIG_VPE_OPERATIONS;

		property_id = HAL_CONFIG_VPE_OPERATIONS;

		operations.rotate = venc_v4l2_to_hal(

				V4L2_CID_MPEG_VIDC_VIDEO_ROTATION,

				ctrl->val);
@@ -2233,8 +2221,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		qpp = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_P_FRAME_QP);

		qpb = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP);



		property_id =

			HAL_PARAM_VENC_SESSION_QP;

		property_id = HAL_PARAM_VENC_SESSION_QP;

		quantization.qpi = ctrl->val;

		quantization.qpp = qpp->val;

		quantization.qpb = qpb->val;
@@ -2249,8 +2236,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		qpi = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP);

		qpb = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP);



		property_id =

			HAL_PARAM_VENC_SESSION_QP;

		property_id = HAL_PARAM_VENC_SESSION_QP;

		quantization.qpp = ctrl->val;

		quantization.qpi = qpi->val;

		quantization.qpb = qpb->val;
@@ -2265,8 +2251,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		qpi = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP);

		qpp = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_H264_P_FRAME_QP);



		property_id =

			HAL_PARAM_VENC_SESSION_QP;

		property_id = HAL_PARAM_VENC_SESSION_QP;

		quantization.qpb = ctrl->val;

		quantization.qpi = qpi->val;

		quantization.qpp = qpp->val;
@@ -2357,8 +2342,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		if (temp)

			temp_ctrl = TRY_GET_CTRL(temp);



		property_id =

			HAL_PARAM_VENC_MULTI_SLICE_CONTROL;

		property_id = HAL_PARAM_VENC_MULTI_SLICE_CONTROL;

		multi_slice_control.multi_slice = ctrl->val;

		multi_slice_control.slice_size = temp ? temp_ctrl->val : 0;
@@ -2370,8 +2354,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
	case V4L2_CID_MPEG_VIDEO_MULTI_SLICE_GOB:

		temp_ctrl = TRY_GET_CTRL(V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE);



		property_id =

			HAL_PARAM_VENC_MULTI_SLICE_CONTROL;

		property_id = HAL_PARAM_VENC_MULTI_SLICE_CONTROL;

		multi_slice_control.multi_slice = temp_ctrl->val;

		multi_slice_control.slice_size = ctrl->val;

		pdata = &multi_slice_control;
@@ -2402,8 +2385,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		air_ref = TRY_GET_CTRL(V4L2_CID_MPEG_VIDC_VIDEO_AIR_REF);

		cir_mbs = TRY_GET_CTRL(V4L2_CID_MPEG_VIDC_VIDEO_CIR_MBS);



		property_id =

			HAL_PARAM_VENC_INTRA_REFRESH;

		property_id = HAL_PARAM_VENC_INTRA_REFRESH;



		intra_refresh.mode = ctrl->val;

		intra_refresh.air_mbs = air_mbs->val;
@@ -2535,8 +2517,7 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		break;

	}

	case V4L2_CID_MPEG_VIDEO_HEADER_MODE:

		property_id =

			HAL_PARAM_VENC_SYNC_FRAME_SEQUENCE_HEADER;

		property_id = HAL_PARAM_VENC_SYNC_FRAME_SEQUENCE_HEADER;



		switch (ctrl->val) {

		case V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE:
@@ -2724,10 +2705,10 @@ static int try_set_ctrl(struct msm_vidc_inst *inst, struct v4l2_ctrl *ctrl) 
		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_PERF_MODE:

		property_id = HAL_CONFIG_VENC_PERF_MODE;

		venc_mode.mode = ctrl->val;

		venc_mode = ctrl->val;

		pdata = &venc_mode;

		msm_dcvs_enc_set_power_save_mode(inst,

			venc_mode.mode == V4L2_MPEG_VIDC_VIDEO_PERF_POWER_SAVE);

			ctrl->val == V4L2_MPEG_VIDC_VIDEO_PERF_POWER_SAVE);

		break;

	case V4L2_CID_MPEG_VIDC_VIDEO_HIER_B_NUM_LAYERS:

		if (inst->fmts[CAPTURE_PORT]->fourcc != V4L2_PIX_FMT_HEVC) {

drivers/media/platform/msm/vidc/vidc_hfi_api.h

+4 −3
Original line number Diff line number Diff line
@@ -1056,15 +1056,16 @@ struct hal_ltr_mark { 
	u32 mark_frame;

};



struct hal_venc_perf_mode {

	u32 mode;

enum hal_perf_mode {

	HAL_PERF_MODE_POWER_SAVE,

	HAL_PERF_MODE_POWER_MAX_QUALITY,

};



struct hal_hybrid_hierp {

	u32 layers;

};



struct hfi_scs_threshold {

struct hal_scs_threshold {

	u32 threshold_value;

};

drivers/media/platform/msm/vidc/vidc_hfi_helper.h

+4 −0
Original line number Diff line number Diff line
@@ -742,6 +742,10 @@ struct hfi_vpe_color_space_conversion { 
	u32 csc_limit[HFI_MAX_LIMIT_COEFFS];

};



struct hfi_scs_threshold {

	u32 threshold_value;

};



#define HFI_ROTATE_NONE					(HFI_COMMON_BASE + 0x1)

#define HFI_ROTATE_90					(HFI_COMMON_BASE + 0x2)

#define HFI_ROTATE_180					(HFI_COMMON_BASE + 0x3)