Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23826850 authored by Ariel Elior's avatar Ariel Elior Committed by David S. Miller
Browse files

bnx2x: align define usage to satisfy static checkers 



Static checkers complained that the E1H_FUNC_MAX define is used
incorrectly in bnx2x_pretend_func(). The complaint was justified,
although its not a real bug, as the first part of the conditional
protects us in this case (a real bug would happen if a VF tried to
use the pretend func, but there are no VFs in E1H chips).

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAriel Elior <ariele@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2efd32ee

drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

+1 −1
Original line number Diff line number Diff line
@@ -13360,7 +13360,7 @@ int bnx2x_pretend_func(struct bnx2x *bp, u16 pretend_func_val) 
{

	u32 pretend_reg;



	if (CHIP_IS_E1H(bp) && pretend_func_val > E1H_FUNC_MAX)

	if (CHIP_IS_E1H(bp) && pretend_func_val >= E1H_FUNC_MAX)

		return -1;



	/* get my own pretend register */