Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21f562dc authored by Matt Wagantall's avatar Matt Wagantall
Browse files

checkpatch: Exceptions for CLK_* macros and some spaces in macros 



Add CLK_* macros used in MSM clock drivers to the list of exceptions
for the "Macros with complex values should be enclosed in parenthesis"
test.

Also, allow spaces following open branckets for macros where the
macro is the first token on the line, the space preceds a decimal
number, and the line ends with ")," or ")". Such arrangements can
be useful for aligning numerical columns of tables when the rows
are described by macros.

Change-Id: I7701119ada2ea8fd646e5448eae51786bbf1e8fa
Signed-off-by: default avatarMatt Wagantall <mattw@codeaurora.org>
(cherry picked from commit ed6d6ed1c6b8f6016ea5676d075331e31b7ac1f8)
Signed-off-by: default avatarStepan Moskovchenko <stepanm@codeaurora.org>
parent 037f3f1d

scripts/checkpatch.pl

+2 −1
Original line number Original line Diff line number Diff line
@@ -3847,7 +3847,7 @@ sub process { 




# check spacing on parentheses

# check spacing on parentheses

		if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&

		if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&

		    $line !~ /for\s*\(\s+;/) {

		    $line !~ /for\s*\(\s+;/ && $line !~ /^\+\s*[A-Z_][A-Z\d_]*\(\s*\d+(\,.*)?\)\,?$/) {

			if (ERROR("SPACING",

			if (ERROR("SPACING",

				  "space prohibited after that open parenthesis '('\n" . $herecurr) &&

				  "space prohibited after that open parenthesis '('\n" . $herecurr) &&

			    $fix) {

			    $fix) {
@@ -4204,6 +4204,7 @@ sub process { 
				MODULE_PARM_DESC|

				MODULE_PARM_DESC|

				DECLARE_PER_CPU|

				DECLARE_PER_CPU|

				DEFINE_PER_CPU|

				DEFINE_PER_CPU|

				CLK_[A-Z\d_]+|

				__typeof__\(|

				__typeof__\(|

				union|

				union|

				struct|

				struct|