Commit 20caa14c authored Sep 28, 2010 by Vasiliy Kulikov Committed by Greg Kroah-Hartman Sep 30, 2010

staging: slicoss: use free_netdev(netdev) instead of kfree()

Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

@@
struct net_device* dev;
@@

-kfree(dev)
+free_netdev(dev)

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Acked-by: Denis Kirjanov <dkirjanov@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent c4711c3a

drivers/staging/slicoss/slicoss.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3233,7 +3233,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
		slic_global.num_slic_cards--;
		slic_card_cleanup(card);
		}
		kfree(dev);
		free_netdev(dev);
		pci_release_regions(pcidev);
		}