Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 206e3f1c authored by Axel Lin's avatar Axel Lin Committed by Jiri Kosina
Browse files

HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw_start() 



Current implementation of hid_hw_start() allows connect_mask to be 0.
Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
necessary. Remove it.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-By: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent bb5c32d9

drivers/hid/hid-picolcd_core.c

+0 −4
Original line number Diff line number Diff line
@@ -565,11 +565,7 @@ static int picolcd_probe(struct hid_device *hdev, 
		goto err_cleanup_data;

	}



	/* We don't use hidinput but hid_hw_start() fails if nothing is

	 * claimed. So spoof claimed input. */

	hdev->claimed = HID_CLAIMED_INPUT;

	error = hid_hw_start(hdev, 0);

	hdev->claimed = 0;

	if (error) {

		hid_err(hdev, "hardware start failed\n");

		goto err_cleanup_data;