Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20359f27 authored by Namhyung Kim's avatar Namhyung Kim Committed by Jens Axboe
Browse files

cfq-iosched: remove unused 'group_changed' in cfq_service_tree_add() 



The 'group_changed' variable is initialized to 0 and never changed, so
checking the variable is meaningless.

It is a leftover from 0bbfeb83 ("cfq-iosched: Always provide group
iosolation."). Let's get rid of it.

Signed-off-by: default avatarNamhyung Kim <namhyung@gmail.com>
Cc: Justin TerAvest <teravest@google.com>
Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
parent 229836bd

block/cfq-iosched.c

+1 −2
Original line number Diff line number Diff line
@@ -1279,7 +1279,6 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, 
	struct cfq_rb_root *service_tree;

	int left;

	int new_cfqq = 1;

	int group_changed = 0;



	service_tree = service_tree_for(cfqq->cfqg, cfqq_prio(cfqq),

						cfqq_type(cfqq));
@@ -1350,7 +1349,7 @@ static void cfq_service_tree_add(struct cfq_data *cfqd, struct cfq_queue *cfqq, 
	rb_link_node(&cfqq->rb_node, parent, p);

	rb_insert_color(&cfqq->rb_node, &service_tree->rb);

	service_tree->count++;

	if ((add_front || !new_cfqq) && !group_changed)

	if (add_front || !new_cfqq)

		return;

	cfq_group_notify_queue_add(cfqd, cfqq->cfqg);

}