Commit 1fc56e86 authored May 23, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman May 30, 2013

staging: comedi: usbduxsigma: remove tidy_up() from (*auto_attach)



Comedi drivers do not need to cleanup allocations during the
(*auto_attach). If the (*auto_attach) fails the (*detach) will
automatically be called to handle the cleanup.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9838f532

drivers/staging/comedi/drivers/usbduxsigma.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1834,10 +1834,8 @@ static int usbduxsigma_auto_attach(struct comedi_device *dev,
		}

		ret = usbduxsigma_alloc_usb_buffers(dev);
		if (ret) {
		tidy_up(devpriv);
		if (ret)
		return ret;
		}

		ret = comedi_load_firmware(dev, &usb->dev, FIRMWARE,
		usbduxsigma_firmware_upload, 0);