Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fa955ba authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: ni_mio_common.c: remove IRQ_POLARITY defines 



Pass the irq_polarity to ni_E_init() and remove the defines.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 32d878a2

drivers/staging/comedi/drivers/ni_atmio.c

+1 −3
Original line number Diff line number Diff line
@@ -264,8 +264,6 @@ static const int ni_irqpin[] = { 
	-1, -1, -1, 0, 1, 2, -1, 3, -1, -1, 4, 5, 6, -1, -1, 7

};



#define IRQ_POLARITY 0



#include "ni_mio_common.c"



static struct pnp_device_id device_ids[] = {
@@ -402,7 +400,7 @@ static int ni_atmio_attach(struct comedi_device *dev, 


	/* generic E series stuff in ni_mio_common.c */



	ret = ni_E_init(dev, ni_irqpin[dev->irq]);

	ret = ni_E_init(dev, ni_irqpin[dev->irq], 0);

	if (ret < 0)

		return ret;

drivers/staging/comedi/drivers/ni_mio_common.c

+3 −2
Original line number Diff line number Diff line
@@ -5604,7 +5604,8 @@ static int ni_alloc_private(struct comedi_device *dev) 
	return 0;

}



static int ni_E_init(struct comedi_device *dev, unsigned interrupt_pin)

static int ni_E_init(struct comedi_device *dev,

		     unsigned interrupt_pin, unsigned irq_polarity)

{

	const struct ni_board_struct *board = comedi_board(dev);

	struct ni_private *devpriv = dev->private;
@@ -5905,7 +5906,7 @@ static int ni_E_init(struct comedi_device *dev, unsigned interrupt_pin) 


	if (dev->irq) {

		ni_stc_writew(dev,

			      (IRQ_POLARITY ? Interrupt_Output_Polarity : 0) |

			      (irq_polarity ? Interrupt_Output_Polarity : 0) |

			      (Interrupt_Output_On_3_Pins & 0) |

			      Interrupt_A_Enable | Interrupt_B_Enable |

			      Interrupt_A_Output_Select(interrupt_pin) |

drivers/staging/comedi/drivers/ni_mio_cs.c

+1 −3
Original line number Diff line number Diff line
@@ -137,8 +137,6 @@ static const struct ni_board_struct ni_boards[] = { 
#endif

};



#define IRQ_POLARITY 1



#include "ni_mio_common.c"



static const void *ni_getboardtype(struct comedi_device *dev,
@@ -203,7 +201,7 @@ static int mio_cs_auto_attach(struct comedi_device *dev, 


	devpriv = dev->private;



	return ni_E_init(dev, 0);

	return ni_E_init(dev, 0, 1);

}



static void mio_cs_detach(struct comedi_device *dev)

drivers/staging/comedi/drivers/ni_pcimio.c

+1 −3
Original line number Diff line number Diff line
@@ -1042,8 +1042,6 @@ static const struct ni_board_struct ni_boards[] = { 
	},

};



#define IRQ_POLARITY 1



#include "ni_mio_common.c"



static int pcimio_ai_change(struct comedi_device *dev,
@@ -1271,7 +1269,7 @@ static int pcimio_auto_attach(struct comedi_device *dev, 
			dev->irq = irq;

	}



	ret = ni_E_init(dev, 0);

	ret = ni_E_init(dev, 0, 1);

	if (ret < 0)

		return ret;