Commit 1f8f4559 authored Sep 28, 2007 by Micah Gruber Committed by David S. Miller Oct 10, 2007

Fix a potential NULL pointer dereference in uli526x_interrupt() in drivers/net/tulip/uli526x.c



This patch fixes an apparent potential null dereference bug where we
dereference dev before a null check.  This patch simply remvoes the
can't-happen test for a null pointer.

Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Acked-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 13f7b8c0

drivers/net/tulip/uli526x.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int irq, void *dev_id)
		unsigned long ioaddr = dev->base_addr;
		unsigned long flags;

		if (!dev) {
		ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
		return IRQ_NONE;
		}

		spin_lock_irqsave(&db->lock, flags);
		outl(0, ioaddr + DCR7);