Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f8c744f authored by Manoj Prabhu B's avatar Manoj Prabhu B Committed by Gerrit - the friendly Code Review server
Browse files

diag: dci: Fix possible race condition during SSR 



This patch fixes the possible race condition
because of the stray dci_mutex unlock statements.

CRs-Fixed: 1027461
Change-Id: I10f3c6d1e2d3c6e71be04e3206273aad7971a6b5
Signed-off-by: default avatarManoj Prabhu B <bmanoj@codeaurora.org>
parent cc957303

drivers/char/diag/diag_dci.c

+0 −2
Original line number Diff line number Diff line
@@ -2897,7 +2897,6 @@ int diag_dci_deinit_client(struct diag_dci_client_tbl *entry) 
		diag_update_userspace_clients(DCI_LOG_MASKS_TYPE);

	ret = dci_ops_tbl[token].send_log_mask(token);

	if (ret != DIAG_DCI_NO_ERROR) {

		mutex_unlock(&driver->dci_mutex);

		return ret;

	}

	kfree(entry->dci_event_mask);
@@ -2906,7 +2905,6 @@ int diag_dci_deinit_client(struct diag_dci_client_tbl *entry) 
		diag_update_userspace_clients(DCI_EVENT_MASKS_TYPE);

	ret = dci_ops_tbl[token].send_event_mask(token);

	if (ret != DIAG_DCI_NO_ERROR) {

		mutex_unlock(&driver->dci_mutex);

		return ret;

	}