Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f5a81e4 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: Make sure the MOVE_EXT ioctl can't overwrite append-only files 



Dan Roseberg has reported a problem with the MOVE_EXT ioctl.  If the
donor file is an append-only file, we should not allow the operation
to proceed, lest we end up overwriting the contents of an append-only
file.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com>
parent 67a3e12b

fs/ext4/move_extent.c

+3 −0
Original line number Diff line number Diff line
@@ -960,6 +960,9 @@ mext_check_arguments(struct inode *orig_inode, 
		return -EINVAL;

	}



	if (IS_IMMUTABLE(donor_inode) || IS_APPEND(donor_inode))

		return -EPERM;



	/* Ext4 move extent does not support swapfile */

	if (IS_SWAPFILE(orig_inode) || IS_SWAPFILE(donor_inode)) {

		ext4_debug("ext4 move extent: The argument files should "