Commit 1f0e79c6 authored Aug 22, 2017 by Dan Carpenter Committed by Greg Kroah-Hartman Nov 30, 2017

eCryptfs: use after free in ecryptfs_release_messaging()



commit db86be3a12d0b6e5c5b51c2ab2a48f06329cb590 upstream.

We're freeing the list iterator so we should be using the _safe()
version of hlist_for_each_entry().

Fixes: 88b4a07e ("[PATCH] eCryptfs: Public key transport mechanism")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e69699d4

fs/ecryptfs/messaging.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -442,13 +442,14 @@ void ecryptfs_release_messaging(void)
		}
		if (ecryptfs_daemon_hash) {
		struct ecryptfs_daemon *daemon;
		struct hlist_node *n;
		int i;

		mutex_lock(&ecryptfs_daemon_hash_mux);
		for (i = 0; i < (1 << ecryptfs_hash_bits); i++) {
		int rc;

		hlist_for_each_entry(daemon,
		hlist_for_each_entry_safe(daemon, n,
		&ecryptfs_daemon_hash[i],
		euid_chain) {
		rc = ecryptfs_exorcise_daemon(daemon);