Commit 1eddd977 authored Dec 17, 2012 by Jingoo Han Committed by Linus Torvalds Dec 17, 2012

drivers/video/backlight/lms283gf05.c: use GPIOF_INIT flags when using devm_gpio_request_one()



GPIOF_DIR_OUT and GPIOF_DIR_IN are defined as below:

   GPIOF_DIR_OUT   (0 << 0)
   GPIOF_DIR_IN    (1 << 0)

So, when !pdata->reset_inverted is 1, the gpio pin can be set as
input, instead of output.

To prevent this problem, GPIOF_INIT flag should be used when using
devm_gpio_request_one().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 424e06e3

drivers/video/backlight/lms283gf05.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,8 @@ static int lms283gf05_probe(struct spi_device *spi)

		if (pdata != NULL) {
		ret = devm_gpio_request_one(&spi->dev, pdata->reset_gpio,
		GPIOF_DIR_OUT \| !pdata->reset_inverted,
		GPIOF_DIR_OUT \| (!pdata->reset_inverted ?
		GPIOF_INIT_HIGH : GPIOF_INIT_LOW),
		"LMS285GF05 RESET");
		if (ret)
		return ret;