Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e87a245 authored by Kees Cook's avatar Kees Cook Committed by Jiri Kosina
Browse files

HID: picolcd_core: validate output report details 



A HID device could send a malicious output report that would cause the
picolcd HID driver to trigger a NULL dereference during attr file writing.

[jkosina@suse.cz: changed

	report->maxfield < 1

to

	report->maxfield != 1

as suggested by Bruno].

CVE-2013-2899

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Cc: stable@kernel.org
Reviewed-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Acked-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 9e891025

drivers/hid/hid-picolcd_core.c

+1 −1
Original line number Diff line number Diff line
@@ -290,7 +290,7 @@ static ssize_t picolcd_operation_mode_store(struct device *dev, 
		buf += 10;

		cnt -= 10;

	}

	if (!report)

	if (!report || report->maxfield != 1)

		return -EINVAL;



	while (cnt > 0 && (buf[cnt-1] == '\n' || buf[cnt-1] == '\r'))