Commit 1ced2353 authored Dec 01, 2015 by Eric Dumazet Committed by Sasha Levin Dec 14, 2015

ipv6: sctp: implement sctp_v6_destroy_sock()



[ Upstream commit 602dd62dfbda3e63a2d6a3cbde953ebe82bf5087 ]

Dmitry Vyukov reported a memory leak using IPV6 SCTP sockets.

We need to call inet6_destroy_sock() to properly release
inet6 specific fields.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

parent 18c103ad

net/sctp/socket.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -7393,6 +7393,13 @@ struct proto sctp_prot = {

		#if IS_ENABLED(CONFIG_IPV6)

		#include <net/transp_v6.h>
		static void sctp_v6_destroy_sock(struct sock *sk)
		{
		sctp_destroy_sock(sk);
		inet6_destroy_sock(sk);
		}

		struct proto sctpv6_prot = {
		.name = "SCTPv6",
		.owner = THIS_MODULE,
		@@ -7402,7 +7409,7 @@ struct proto sctpv6_prot = {
		.accept = sctp_accept,
		.ioctl = sctp_ioctl,
		.init = sctp_init_sock,
		.destroy = sctp_destroy_sock,
		.destroy = sctp_v6_destroy_sock,
		.shutdown = sctp_shutdown,
		.setsockopt = sctp_setsockopt,
		.getsockopt = sctp_getsockopt,